support for a custom apt source release #1561
Conversation
h0tw1r3
requested review from
alexjfisher,
bastelfreak,
deric,
ekohl,
SimonHoenscheid,
smortex and
a team
as code owners
There was a problem hiding this comment.
IMHO we shouldn't do this and instead drop 18.04. The standard support of 18.04 has ended and clearly PostgreSQL no longer wants to supports it since they dropped it from their repositories (on 2023-11-05 according to https://wiki.postgresql.org/wiki/Apt#News).
If anything, we can introduce a parameter to apt_postgresql_org for the release so you can override it via Hiera. In fact, I think that'd be wise for everything including the GPG keys.
h0tw1r3
force-pushed
the
fix-ubuntu-18-repo
branch
from
bcb9dbb to
503bee0
Compare
Useful in cases where postgresql has archived support for the platform.
h0tw1r3
force-pushed
the
fix-ubuntu-18-repo
branch
from
503bee0 to
29ef7ff
Compare
Reworked. Thanks for the constructive feedback. I think the overall design pattern could use attention which is why I'm not touching key management yet. |
h0tw1r3
changed the title
| postgresql::repo::baseurl: https://apt-archive.postgresql.org/pub/repos/apt/ | ||
| postgresql::repo::release: "%{facts.os.distro.codename}-pgdg-archive" |
There was a problem hiding this comment.
Having archive repos is much cleaner than using a different distro. I much prefer this.
There was a problem hiding this comment.
I think the overall design pattern could use attention which is why I'm not touching key management yet.
I think #1563 would be a major step in that direction. If you just need to provide a URL without an ID then it's way easier.
Postgresql no longer specifically supports Ubuntu 18.04, but still supports Debian 10 which can be used until Puppet drops support for Ubuntu 18.04.
Summary
Postgresql recommends using the Debian buster repo for Ubuntu bionic.
Additional Context
Temporary until Puppet no longer supports Ubuntu 18.04.
Related Issues (if any)
voxpupuli/puppet-puppetboard#402
Checklist